C5_W4_A1 UNQ_C4 through UNQ_C7 dimension comment errors

The last dimensions of many of the variables in UNQ_C4 through UNQ_C7 are labeled incorrectly I think; all the fully_connected_dim should instead be embedding_dim. For instance, the input argument x in UNQ_C4 should have shape (batch_size, input_seq_len, embedding_dim) rather than (batch_size, input_seq_len, fully_connected_dim). Please let me know if I’m missing something.

Personally I find the labels in the code comments confusing, and I don’t use them.

I’ll forward your comment to the authors.

1 Like