Hi,
I was going over the implementation of the positional embeddings.
Wherein the test example,
# Example
position = 4
d_model = 8
pos_m = np.arange(position)[:, np.newaxis]
dims = np.arange(d_model)[np.newaxis, :]
get_angles(pos_m, dims, d_model)
Is used to get the angles, my question has been on the choice of how we are deciding the dimensions of the pos_m
argument and the dims
argument. ie how did we decide the new axis for the pos_m
should make the shape of pos_m
be len(range(pos_m)),1
and dims be 1, len(range(d))
Following the note in the exercise
Note: In the lectures Andrew uses vertical vectors, but in this assignment all vectors are horizontal. All matrix multiplications should be adjusted accordingly.
My presumption was that then all vectors should be horizontal vectors, why is that not the case?